search

adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt
GNU General Public License v3.0
14 stars 42 forks source link

Possible issue if course.json does not contain "_spoor" element #299

Closed paulstevendev closed 8 months ago

paulstevendev commented 10 months ago

When testing in the authoring tool using the latest adapt-contrib-spoor I do not see any reference to "_spoor" in the course.json file of the published SCORM zip file.

Therefore I question whether this is going to cause an issue here:

const config = Adapt.course.get('_spoor');

https://github.com/adaptlearning/adapt-contrib-spoor/blob/4370780b00d734819159acb866ace308d5ec59f0/js/scorm/wrapper.js#L549C1-L551C74

The code will hang here surely if there is no "_spoor" element present in course.json

paulstevendev commented 10 months ago

Possibly related to this issue https://github.com/adaptlearning/adapt-contrib-spoor/issues/283

paulstevendev commented 10 months ago

course.json Attached course.json from published course from open source authoring tool using Spoor 5.9.3 and the following Adapt authoring tool 0.11.2. Adapt framework v5.33.4 You will see there is no "_spoor" element in course.json

oliverfoster commented 8 months ago

Confirmed working with no _spoor in course.json now.