Error messaging lost if course is not yet loaded

adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt

GNU General Public License v3.0

14 stars 42 forks source link

Closed danielghost closed 10 months ago

danielghost commented 10 months ago

If an error occurs before Adapt.course has loaded, the error message will be lost. Instead of returning early as per the changes in https://github.com/adaptlearning/adapt-contrib-spoor/commit/cb3d93faecee4fa046088c192b1efd6700d0630d, the error handling should be delayed by adding:

if (!Data.isReady) await Data.whenReady();

github-actions[bot] commented 10 months ago

:tada: This issue has been resolved in version 5.9.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: