Fix: delay error messaging until all course data is ready

adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt

GNU General Public License v3.0

14 stars 42 forks source link

Closed danielghost closed 10 months ago

danielghost commented 10 months ago

Fixes #300, #283.

Delay error messaging until all course data is ready.
Allows other plugins handling errors to listen to error events before they have been fired.

danielghost commented 10 months ago

@joe-allen-89 - please can you check this doesn't impact the fix applied for #284?

github-actions[bot] commented 10 months ago

:tada: This PR is included in version 5.9.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

paulstevendev commented 10 months ago

Does this fix https://github.com/adaptlearning/adapt-contrib-spoor/issues/283 Issue https://github.com/adaptlearning/adapt-contrib-spoor/issues/283 looks to be the same issue that I raised https://github.com/adaptlearning/adapt-contrib-spoor/issues/299 about. The issue occurs when no custom error messages have been added so there is no reference to "_spoor" in the course.json and hence there is a script error resulting in the course just hanging on the loading screen.