Fix: Changed logic for 401 error handling

adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt

GNU General Public License v3.0

14 stars 42 forks source link

Fix: Changed logic for 401 error handling #303

Closed danielghost closed 9 months ago

danielghost commented 10 months ago

Fixes #302.

Fix

Changed logic for 401 error handling so calls to unsupported data elements will fail silently.

oliverfoster commented 10 months ago

Do the if (!this.scorm.isSupported('xxx')) return; calls work in some situations currently?

If so, it might be wise to leave them in there rather than making a known 401 call.

danielghost commented 10 months ago

Do the if (!this.scorm.isSupported('xxx')) return; calls work in some situations currently?

If so, it might be wise to leave them in there rather than making a known 404 call.

They still work, but see https://github.com/adaptlearning/adapt-contrib-spoor/issues/302#issuecomment-1842909533 to help decide if these should remain.

github-actions[bot] commented 9 months ago

:tada: This PR is included in version 5.9.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: