search

adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt
GNU General Public License v3.0
14 stars 42 forks source link

Unsupported logic #304

Closed danielghost closed 8 months ago

danielghost commented 10 months ago

In addition to the changes made for #302, the unsupported logic should change to check which child elements are supported, as per the spec:

datamodel.element._children The _children keyword is used to determine all of the elements in a group or category that are supported by the LMS.

LMSGetValue(datamodel.group._children) The return value is a comma-separated list of all of the element names in the specified group or category that are supported by the LMS. If an element has no children, but is supported, an empty string ("") is returned. An empty string ("") is also returned if an element is not supported. A subsequent request for last error [LMSGetLastError()] can determine if the element is not supported. The error “401 Not implemented error” indicates the element is not supported.

The current method of just checking _count could lead to errors being raised where not all the child elements are supported.

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 5.9.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: