search

adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt
GNU General Public License v3.0
14 stars 42 forks source link

Error logging order #307

Closed danielghost closed 8 months ago

danielghost commented 8 months ago

The logged SCORM calls are out of sync when adding errors, due to the deferred handling. The logs would be easier to analyse if the error entries followed the associated get/set calls rather than appearing at the end of the stack.

The reverted change of https://github.com/adaptlearning/adapt-contrib-spoor/pull/303/commits/3f68ac6663df4c80d50477394d274f6d831c82e8 (previously reverted to be handled in a separate PR) should be implemented accordingly so only the notification is deferred, keeping the logs in sync with the execution order.

github-actions[bot] commented 8 months ago

:tada: This issue has been resolved in version 5.9.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: