adaptlearning / adapt-contrib-spoor

A basic scorm tracking plugin for Adapt
GNU General Public License v3.0
14 stars 42 forks source link

cmi.objectives issues #316

Closed oliverfoster closed 5 months ago

oliverfoster commented 6 months ago

Reference

Forum post: https://community.adaptlearning.org/mod/forum/discuss.php?d=4223 LMS: KnowBe4 Original pr for addition of the cmi.objectives behaviour: https://github.com/adaptlearning/adapt-contrib-spoor/pull/280

...KnowBe4 won't let you continue if there are any errors. You can upload your package but cannot add it to any training. The support folks have been good about manually pushing it through for us, but we are going to have monthly training for the next year or so and they always need to be uploaded, viewed by others, then edited and uploaded again. With the need to contact support each time it makes this a lengthy process. That is the impact I was trying to avoid.

Issues

https://github.com/adaptlearning/adapt-contrib-spoor/blob/df90b8dacbe8c20e12e1d57dfd1cdfc37de82903/example.json#L8

https://github.com/adaptlearning/adapt-contrib-spoor/blob/df90b8dacbe8c20e12e1d57dfd1cdfc37de82903/js/scorm/wrapper.js#L704

https://github.com/adaptlearning/adapt-contrib-spoor/blob/df90b8dacbe8c20e12e1d57dfd1cdfc37de82903/js/scorm/wrapper.js#L713

https://github.com/adaptlearning/adapt-contrib-spoor/blob/df90b8dacbe8c20e12e1d57dfd1cdfc37de82903/js/scorm/wrapper.js#L730

The code should check for objective existence before setting the id so as not to unnecessarily reset it.

github-actions[bot] commented 5 months ago

:tada: This issue has been resolved in version 5.9.8 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: