search

adaptlearning / adapt-contrib-xapi

TinCan/xAPI extension for the Adapt Framework
GNU General Public License v3.0
12 stars 28 forks source link

Activity type for interactions should be http://adlnet.gov/expapi/activities/cmi.interaction #63

Closed garemoko closed 1 year ago

garemoko commented 5 years ago

The xAPI spec states

Interaction Activities SHOULD have the Activity type http://adlnet.gov/expapi/activities/cmi.interaction

This means that questions, because they use the special Interaction Activity properties, should use this activity type. Instead they use http://adlnet.gov/expapi/activities/question.

See: https://github.com/adaptlearning/adapt-contrib-xapi/blob/7f148b69e6d774130a02513046beeb4249ac60d7/js/adapt-contrib-xapi.js#L522

But actually this is the code that get's used: https://github.com/adaptlearning/adapt-contrib-xapi/blob/7f148b69e6d774130a02513046beeb4249ac60d7/js/adapt-contrib-xapi.js#L572

Looks like this might also be an issue with the ADL Wrapper since cmi.interaction is not listed https://github.com/adlnet/xAPIWrapper/blob/master/src/activitytypes.js#L7

brian-learningpool commented 5 years ago

Hi @garemoko, thanks for raising. It looks like this was changed in https://github.com/adaptlearning/adapt-contrib-xapi/commit/0e690ece99bf7d4cbe278a48d0dbabd3131ca8ea.

I've raised the missing cmi.interaction activity type at https://github.com/adlnet/xAPIWrapper/issues/152.

brian-learningpool commented 5 years ago

PR for this issue is now up at https://github.com/adlnet/xAPIWrapper/pull/154.

oliverfoster commented 1 year ago

closed stale