search

adaptlearning / adapt-contrib-xapi

TinCan/xAPI extension for the Adapt Framework
GNU General Public License v3.0
12 stars 28 forks source link

Calls to addGroupingActivity() clear out any existing array entries #78

Closed brian-learningpool closed 4 years ago

brian-learningpool commented 4 years ago

Multiple calls to addGroupingActivity() in the xAPIWrapper, e.g. overwrite any existing array values.

For example, according to https://github.com/adaptlearning/adapt-contrib-xapi/blob/master/js/adapt-contrib-xapi.js#L805-L836 a question component which is part of an assessment should contain groupings for:

In fact, only the assessment grouping is present, due to it being the last call to statement.addGroupingActivity().

This is caused by https://github.com/adlnet/xAPIWrapper/issues/160.

brian-learningpool commented 4 years ago

Pull request is up on xAPIWrapper repo. I'll update our code as soon as it's merged.