adaptlearning / adapt-contrib-xapi

TinCan/xAPI extension for the Adapt Framework
GNU General Public License v3.0
12 stars 27 forks source link

issues/88 #90

Closed cahirodoherty-learningpool closed 2 years ago

cahirodoherty-learningpool commented 3 years ago

Display language based off _activeLanguage on initializeWrapper and set on onLanguageChanged

Part solution to issues/88 in combination with https://github.com/adaptlearning/adapt-contrib-languagePicker/pull/46

deltanetdan commented 3 years ago

@cahirodoherty-learningpool which part of issues/88 does this fix?

cahirodoherty-learningpool commented 3 years ago

@cahirodoherty-learningpool which part of issues/88 does this fix?

Hi Dan, this is tied to issue 88 in that it will allow xAPI to set the active language and the language picker will pick this up on return to the course. The work on language picker also allows for a param to be passed to set this language on first run if desired

deltanetdan commented 3 years ago

Thanks Cahir, do I need to change any config? I tested with latest FW and both xAPI and language picker issues/88 branches and still get the language picker menu on return. I've set xapi _shouldTrackState = true and language picker _showOnCourseLoad = true as per the issue.

Note: testing on SCORM cloud.

cahirodoherty-learningpool commented 3 years ago

Thanks Cahir, do I need to change any config? I tested with latest FW and both xAPI and language picker issues/88 branches and still get the language picker menu on return. I've set xapi _shouldTrackState = true and language picker _showOnCourseLoad = true as per the issue.

Note: testing on SCORM cloud.

Hi Dan, you're right. I need to take another look at this

oliverfoster commented 2 years ago

closing as stale and in conflict