search

adaptlearning / adapt-vimeo

A Vimeo Player Component for the Adapt Framework
GNU General Public License v3.0
0 stars 2 forks source link

Feature/adapt vimeo #1

Closed danielstorey closed 5 years ago

oliverfoster commented 5 years ago

Is it necessary to have the vimeo player in the libraries folder, as opposed to it being downloaded from a cdn?

Any advantages?

https://developer.vimeo.com/player/sdk/basics https://github.com/vimeo/player.js

danielstorey commented 5 years ago

Is it necessary to have the vimeo player in the libraries folder, as opposed to it being downloaded from a cdn?

Any advantages?

https://developer.vimeo.com/player/sdk/basics https://github.com/vimeo/player.js

Fair point. Maybe including the library provides some protection against possible future updates which might break stuff?!

moloko commented 5 years ago

@oliverfoster we have a few clients who require that e-learning content is completely self-contained i.e. doesn't use any code or assets loaded from external servers. So it would be preferable for it to be in the libraries folder from that point of view.

oliverfoster commented 5 years ago

@moloko I'm not sure if that's possible in this situation as the video must be loaded from vimeo, which is an external platform.

@danielstorey I guess it depends which changes would cause the break? If the client code changes to suit a new server-side API then having the client code fixed against a redundant server-side API would be a problem. Equally, if the client side code changes significantly enough to break Adapt, that isn't good either.

moloko commented 5 years ago

I'm not sure if that's possible in this situation as the video must be loaded from vimeo, which is an external platform.

oh yeah! derp ;-)

oliverfoster commented 5 years ago

I happy to leave as is. I just wanted to ask. 👍