adaptlearning / adapt_authoring

A server-based user interface for authoring eLearning courses using the Adapt framework.
https://www.adaptlearning.org/
GNU General Public License v3.0
519 stars 285 forks source link

Context help when selecting an external image asset #1323

Open erichgoldman opened 8 years ago

erichgoldman commented 8 years ago

When adding an image asset you have two button: Select an Asset and Select an External Asset

image

Clicking Select an Asset bring you to the built in asset chooser so the context is clear enough, however, when you click Select an External Asset the only change is an inline text field on the same page.

It is not immediately clear that this where a hyperlink is supposed to go. My recommendation would be to add "helper text" above to say something like "Enter the web address (URL) of the image you would like to use". In addition, you can preset the text in the html block using placeholder attribute to be http://. Alternatively, if not adding helper text you can have it prefilled with the instruction:

For example, edit the following snippet in scaffoldAsset.hbs:

<input 
    type="text" 
    class="scaffold-asset-external-input-field" 
    placeholder="Enter the web address (URL) of the image here, then click save"
/>

image

Further, it is not quite clear why the button for Select an External Asset is a different style then the Select an Asset. This makes it looks like a toggle instead of two separate buttons.

taylortom commented 7 years ago

The thinking style-wise is that it's the secondary action here. Happy to discuss changing this.

I think a simple change of label will suffice here, possibly something like 'Use asset at URL'.

taylortom commented 6 years ago

TODO: need a (localised) placeholder here: scaffoldAsset.hbs#L53