search

adaptlearning / adapt_authoring

A server-based user interface for authoring eLearning courses using the Adapt framework.
https://www.adaptlearning.org/
GNU General Public License v3.0
515 stars 284 forks source link

Custom LESS is not included in import #2490

Open canstudios-nicolaw opened 4 years ago

canstudios-nicolaw commented 4 years ago

Expected Behaviour

If I have a course with custom LESS, I should be able to export/import it and retain the custom LESS.

Actual Behaviour

The custom LESS does not get imported.

Steps to Reproduce

  1. Create a course with custom LESS
  2. Export it, note that the less is contained in src/theme/[theme name]/less/zzzzz/
  3. Import the course, note that the LESS has not been imported

Versions

Note: it seems that this has been a problem in the past https://github.com/adaptlearning/adapt_authoring/issues/2088

davetaz commented 2 years ago

Expanding on this. If the custom less is defined under project settings in the AAT, this is exported as a custom less file under zzzz. This is, in my view, the wrong behaviour for the export as it should export the custom less in the course config files not in a less file. The less file should only be output as part of the build (not source export).

This way the custom less would be put back where it was defined in the AAT interface.

The only way the custom less can be imported currently is if the theme version on the AAT you are importing into is behind that of the source.