search

adaptlearning / adapt_authoring

A server-based user interface for authoring eLearning courses using the Adapt framework.
https://www.adaptlearning.org/
GNU General Public License v3.0
513 stars 278 forks source link

Unable to upgrade to latest tag #2515

Open tomgreenfield opened 4 years ago

tomgreenfield commented 4 years ago

Expected Behaviour

An automatic upgrade is able to be performed.

Actual Behaviour

Attempting an upgrade from framework 5.5 to framework 5.5.1 is giving me the following message:

Software updates found.
Failed to upgrade /temp/xxxx/adapt_framework to v5.5.1
ERROR: error: pathspec 'v5.5.1' did not match any file(s) known to git.
Upgrade was unsuccessful. Please check the console output.

It's almost as if the git fetch here isn't running or bringing down the latest remote tag: https://github.com/adaptlearning/adapt_authoring/blob/28247b0da4b41a486216fbeb3b870e8b2e97155e/lib/installHelpers.js#L524

This also happens if I specify the tag in the upgrade script.

It fixes itself if I run git fetch manually in the adapt_framework directory.

Steps to Reproduce

May be tricky to reproduce because you need to be not in sync with the remote.

node upgrade --continue y --updateAutomatically y

Versions

tomgreenfield commented 4 years ago

Have retested on two different instances today and there were no problems with the fetch - the latest framework tag was successfully pulled down. Closing for now until it can be reproduced.

chucklorenz commented 2 years ago

Receiving the same error trying to update AT v0.10.2 FWv4.4.1 on Ubuntu.

Adapt authoring tool upgraded to v0.10.5
Failed to upgrade /temp/5d53965298b7a35faa105594/adapt_framework to v4.5.0
ERROR: error: pathspec 'v4.5.0' did not match any file(s) known to git.

Notice message says AT upgrade succeeded; FW update failed. When it failed, I checked my node version and updated adapt-cli. Now using node v14.15.4 and CLI v2.1.13. Interesting, when I run adapt version, CLI reports: 

CLI: 2.1.13
Framework: 0.10.5

"0.10.5" is the AT version, not the FW version.

I tried installing with: