Closed simondate closed 4 years ago
This could also be fixed by changing the PLP extension code to be more defensive (accommodating of incomplete JSON).
I agree and I think we should do this as well
Could we just do the PLP defensive code and not remove the indicators from the default course?
Could we just do the PLP defensive code and not remove the indicators from the default course?
We should definitely do the defensive code but @simondate has not actually removed the indicators from the default course
As Matt said I made the JSON reflect what is currently in the pre-installed course.
I've never used this PLP functionality myself. I like having it half on and half off to show that there is a choice.
Sweet, I misunderstood then. Ta :+1:
do the defensive code bit
@simondate what was the original error / problem / point of failure? can I have the console log or similar?
The course wouldn't run when you imported it. There was an error in the developer console that mentioned _isCompletionIndicatorEnabled
As you can see from this search https://github.com/adaptlearning/adapt-contrib-pageLevelProgress/search?q=_isCompletionIndicatorEnabled&unscoped_q=_isCompletionIndicatorEnabled
https://github.com/adaptlearning/adapt-contrib-pageLevelProgress/blob/master/js/adapt-contrib-pageLevelProgress.js#L76 This is the only place _isCompletionIndicatorEnabled
is referenced which would never cause and error. I cannot proceed without more info.
Menu loads but error shows
Any page with a component with the missing attribute doesn't load.
Subject of the issue/enhancement/features
When you create the framework using
adapt create course
the JSON for Page Level Progress isn't complete and breaks what should be a direct import into the Authoring Tool.I propose updating the JSON so that a direct import is possible.
This could also be fixed by changing the PLP extension code to be more defensive (accommodating of incomplete JSON).
Your environment
Steps to reproduce
Tell us how to reproduce this issue.
1) create a course using
adapt create course
2) Import the course into the Authoring Tool 3) Try to run the course