adaptyteam / AdaptySDK-Flutter

SDK for growing mobile in-app purchases
https://docs.adapty.io/docs/quickstart
MIT License
96 stars 17 forks source link

remoteConfig is returning null #82

Closed akurnaz closed 1 year ago

akurnaz commented 1 year ago

remoteConfig method in AdaptyPaywall is returning null value in production. It is working correct in emulators.

sdkVersion = '2.3.1'

My remote config: Ekran Resmi 2023-03-02 17 04 06 Ekran Resmi 2023-03-02 17 04 38

x401om commented 1 year ago

Hi @akurnaz! Could you please clarify, what to you mean by "production" here? Also it would be great to provide a verbose log from the sdk.

akurnaz commented 1 year ago

@x401om By production I mean "after release". I only see the following message in Crashlytics that occurs where remoteConfig is called. I don't have verbose logs from the sdk. Null check operator used on a null value

x401om commented 1 year ago

@akurnaz As far as I understand the issue is not directly related to the functionality of our SDK. I will ask you to contact our technical support team by email: support@adapty.io. They can help you with your specific account setup. Please let them know that you have already communicated with me in this issue, as well as all the details necessary for them to find your account and the server requests logs. For now, I will not close this issue, but hopefully it will be solved easily.

ibrahimdevs commented 1 year ago

@x401om I think, it is related with Flutter SDK. Everything is normal for my app which is on App Store. (It's adapty_flutter version is 2.2.4). I upgrade the adapty_flutter to 2.4.1 and my paywall's remoteConfig data comes null now.

var paywall = await Adapty().getPaywall(id: "my_paywall_id");

And paywall object's remoteConfig comes null, also I checked remoteConfigString is null too. I didn't change anything on my paywall's remote config data from Adapty Web Panel. Also it is still working on 2.2.4 without any problem.

There is something wrong in Adapty Flutter package, could you check it? It is very big issue, somebody can be affected on production too.

Thanks,

x401om commented 1 year ago

@ibrahimdevs did you fill the localized version of your remote config or you are still using the legacy one?

Since 2.3.0 we have introduced the paywalls localization feature, that's why 2.2.4 works with legacy remote config, and 2.4.1 is not.

ibrahimdevs commented 1 year ago

@x401om Yes, I'm still using the legacy version. I think, if there is available legacy json, you should continue to provide the legacy json. If an update is breaking change, it is better to put "Breaking Change" and inform us with email.

Also it is better to edit docs. https://docs.adapty.io/docs/paywall#localizations

Screenshot 2023-03-23 at 15 07 11

It is important because it effects directly how our paywalls are displayed. It would be a huge loss for me if I didn't notice and sent an update with current latest version.

x401om commented 1 year ago

@ibrahimdevs I apologize that our documentation was not clear enough. We have made some changes to ensure that such an issue will not happen again.

x401om commented 1 year ago

@akurnaz was you able to contact our support team?

akurnaz commented 1 year ago

@x401om I didn't but the problem was solved. You can close this issue.