search

adaptyteam / AdaptySDK-Flutter

SDK for growing mobile in-app purchases
https://docs.adapty.io/docs/quickstart
MIT License
88 stars 15 forks source link

Breaking changes (remove fields localizedPrice, localizedSubscriptionPeriod, etc) without notice #91

Closed al-tush closed 11 months ago

al-tush commented 11 months ago

In version 2.6.0 some fields was removed without update version to 3.0. This is against the rules SemVer https://semver.org/spec/v2.0.0-rc.1.html

MJ12358 commented 11 months ago

Can confirm that the api has breaking changes without a semantic version update.

In my specific use case: AdaptyPaywallProduct.localizedPrice no longer exists and there is no documentation that offers an alternative.

It seems that they have replaced this with AdaptyPaywallProduct.price which points to a new class called AdaptyPrice.

However the comments within that class suggest that amount and localizedString are for "discounts"? Is this correct and if so what do we need to use in favor of localizedPrice?

Edit: From my testing it seems that the new AdaptyPrice.localizedString is analogous to the previous AdaptyPaywallProduct.localizedPrice, but would be nice if the comments are adjusted as such (and of course breaking changes are implemented according to semantic versioning).

x401om commented 11 months ago

Hi there,

I apologize for the difficulties you've encountered while trying to upgrade to the new version. I'd like to clarify that our team currently does not strictly adhere to the SemVer standard, despite the recommendation from Google to do so. The reason behind this is that we are dealing with multiple SDKs across various platforms, necessitating synchronization of versions among them. This practice helps us prevent inconsistencies in documentation and confusion.

Furthermore, it's worth noting that different platforms' SDKs employ diverse approaches to versioning.

Our approach involves using the X.Y.Z notation. We increment the Y value when there are incompatible changes in the public API or when significant functionalities are added. Otherwise, we increment Z. The X component sees an increment in the event of comprehensive SDK overhauls or major product announcements.

I've updated the Release Notes for our most recent major release, aiming to simplify the migration process.

Once again, I apologize for any inconvenience the update may have caused you. We're committed to providing clearer explanations for future changes.

I'll be closing this issue now, but please don't hesitate to ask if you have any further questions.