search

adar2378 / pin_code_fields

A flutter package which will help you to generate pin code fields with beautiful design and animations. Can be useful for OTP or pin code inputs 🤓🤓
https://pub.dev/packages/pin_code_fields
MIT License
677 stars 330 forks source link

Improve focus logic on Android #354

Closed fummicc1 closed 10 months ago

fummicc1 commented 10 months ago

Description

On android, there is a keyboard issue when PinCodeTextField.autoUnfocus is false and app becomes background with focusNode active like this demo.

https://github.com/adar2378/pin_code_fields/assets/44002126/64b28aff-a108-4fec-b1ef-bb1d96b8c144

To fix this issue, I need to use same logic as PinCodeTextField.autoUnfocus is true which is introduced in https://github.com/adar2378/pin_code_fields/pull/242.

What I did

I deleted autoUnfocus property, because it can be better to fix as true.

fummicc1 commented 10 months ago

I realized this change is not appropriate from library side, let me close this PR. 🙇‍♂️