adar2378 / pin_code_fields

A flutter package which will help you to generate pin code fields with beautiful design and animations. Can be useful for OTP or pin code inputs 🤓🤓
https://pub.dev/packages/pin_code_fields
MIT License
677 stars 330 forks source link

Fixing BoxShadows for PinFields #383

Open Pluxury opened 2 weeks ago

Pluxury commented 2 weeks ago

In the pinTheme constructor, null-check is used for the activeBoxShadows and inActiveBoxShadows fields with further assignment of an empty array in the case of null.

But _pinCodeTextFieldState on line 880, the same values are checked for null and in the case of null, the boxShadows widget property should be selected. Since the fields were filled in with the default value, this situation never worked out. This PR corrects incorrect behavior

P.S: and some code style fix