search

adareau / HAL

HAL Atom Locator
GNU General Public License v3.0
2 stars 1 forks source link

90° rotated images displayed #103

Closed quentinmarolleau closed 3 years ago

quentinmarolleau commented 3 years ago

image

Excuse me, wtf ??

adareau commented 3 years ago

Must be because the RawCamDatadata class is selected. You can choose the data type on the gui (and should use Xenics in your case). To ignore the RawCamData, add the following line in your config file:

[global]
ignored modules list = RawCamData
quentinmarolleau commented 3 years ago

well, I don't have the Xenics option in the list for "Data Type". What the RawCamData is intended to do ? If it sets (as it seems when reading it) the parameters like name, scale and whatever, we should use it for our own camera right ?

EDIT: just figured out that your fix is mentioned in README.md... I guess we should sort this out by default right after installation for later users. But I'm still interested in the aim of the class :grimacing:

EDIT2: on the top of it your solution causes an other bug :grin: image

adareau commented 3 years ago

What is this bug ?

adareau commented 3 years ago

well, I don't have the Xenics option in the list for "Data Type". What the RawCamData is intended to do ? If it sets (as it seems when reading it) the parameters like name, scale and whatever, we should use it for our own camera right ?

The RawCamData is just a "default" DataClass for loading picture (basically, it loads pngs). The point is to have a DataClass provided with HAL that works out of the box, without having to code your own picture class right away (and, when you do so, to provide an example).

I agree that the way it works is not ideal, but it is hard to provide both something that can load images out of the box and let the user provide their own classes...

quentinmarolleau commented 3 years ago

I was working on a He1 camera class, but I just realised that you actually already did it in a side repo https://github.com/adareau/HAL-modules