adavoudi / spdnet

Implementation of Deep SPDNet in pytorch
MIT License
58 stars 11 forks source link

Whether the line 172 of spd.py is wrong? #16

Closed SecNet-mi closed 6 months ago

SecNet-mi commented 6 months ago

It is a good implementation on pytorch. But I'm a little confused about spd.py.

Whether the line 172 of spd.py is wrong? It might need to be

u.mm(2*symmetric(P.t() * (u.t().mm(dLdV)))+dLdS).mm(u.t())

In the original paper, this was multiplied by 2. But in this code, probably you ignored this. Would you mind answering a question for me? @adavoudi