Closed PenguinOfWar closed 1 year ago
Have you opened an issue in the Next.js repo?
Have you opened an issue in the Next.js repo?
Logged a bug on next for visibility. vercel/next.js#56480
However as the fix is a minor utility name change in the source (and given the rather large backlog/potentially large turnaround time for the next teams) this felt like the best way to get a quick fix into production and hopefully prevent it from happening on any other bundlers.
Thanks!
Thanks for the merge @nstepien!
Issue
Under certain conditions when bundled, two identically named functions (
isCellEditable
) can clash.How to replicate
next@13.5.4
or laternpm run dev
shows expected functionality of cell becoming editable after double click or carriage returnnpm run build && npm run start
shows an unexpected outcome, cell edit becomes unreachable in productionGoing through the compiled code with some strategic logging shows that the production build version of the code prefers the utility
isCellEditable
rather than the function insideDataGrid
. As they accept two different arguments sets, this breaks the edit feature.Fix
Renaming the utility to
isCellEditableUtil
resolves this issue. If this name isn't preferred, I am open to suggestion and happy to change it.