search

adazzle / react-data-grid

Feature-rich and customizable data grid React component
https://adazzle.github.io/react-data-grid/
Other
6.93k stars 2.18k forks source link

TreeDataGridProps has wrong type for columns #3404

Open tom-weiss opened 9 months ago

tom-weiss commented 9 months ago

TreeDataGridProps has wrong type for columns

Is currently set to: readonly Column<R, SR>[];

Should be readonly ColumnOrColumnGroup<R, SR>[];

To Reproduce

  1. Instantiate a TreeDataGrid with grouped columns

I am happy to create a PR with a fix if you want.

amanmahajan7 commented 9 months ago

TreeDataGrid does not support column groups at the moment and the types are correct.

paustint commented 9 months ago

And FYI, this change was made here https://github.com/adazzle/react-data-grid/pull/3287/files where row grouping was removed from the core Grid and moved into TreeGrid was titied up.

I ended up having to review the diff of releases to identify and fix all the breaking changes when I upgraded from 7.0.0-beta.34 to 7.0.0-beta.41.