adazzle / react-data-grid

Feature-rich and customizable data grid React component
https://adazzle.github.io/react-data-grid/
Other
6.82k stars 2.17k forks source link

Add `NoInfer` to DataGrid & TreeDataGrid prop types #3512

Closed nstepien closed 2 months ago

nstepien commented 2 months ago

https://devblogs.microsoft.com/typescript/announcing-typescript-5-4/#the-noinfer-utility-type

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.21%. Comparing base (59eed81) to head (b604f04). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3512 +/- ## ======================================= Coverage 98.21% 98.21% ======================================= Files 47 47 Lines 5087 5098 +11 Branches 723 723 ======================================= + Hits 4996 5007 +11 Misses 91 91 ``` | [Files](https://app.codecov.io/gh/adazzle/react-data-grid/pull/3512?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adazzle) | Coverage Δ | | |---|---|---| | [src/DataGrid.tsx](https://app.codecov.io/gh/adazzle/react-data-grid/pull/3512?src=pr&el=tree&filepath=src%2FDataGrid.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adazzle#diff-c3JjL0RhdGFHcmlkLnRzeA==) | `99.35% <100.00%> (+<0.01%)` | :arrow_up: | | [src/TreeDataGrid.tsx](https://app.codecov.io/gh/adazzle/react-data-grid/pull/3512?src=pr&el=tree&filepath=src%2FTreeDataGrid.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adazzle#diff-c3JjL1RyZWVEYXRhR3JpZC50c3g=) | `95.92% <100.00%> (+0.02%)` | :arrow_up: |
dalmolinz commented 1 month ago

Edit: Fixed after updating my project's typescript to >= 5.4

this has completely killed type checking in most if not all callbacks

beta.44: no typecheck image image

beta.43: typecheck works image image