adazzle / react-data-grid

Feature-rich and customizable data grid React component
https://adazzle.github.io/react-data-grid/
Other
7.01k stars 2.18k forks source link

Add `aria-description` #3642

Closed amanmahajan7 closed 5 days ago

amanmahajan7 commented 5 days ago

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-description

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.63%. Comparing base (e79641b) to head (4768c96). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3642 +/- ## ========================================== - Coverage 89.71% 89.63% -0.09% ========================================== Files 48 48 Lines 3453 3455 +2 Branches 648 652 +4 ========================================== - Hits 3098 3097 -1 - Misses 355 358 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/adazzle/react-data-grid/pull/3642?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adazzle) | Coverage Δ | | |---|---|---| | [src/DataGrid.tsx](https://app.codecov.io/gh/adazzle/react-data-grid/pull/3642?src=pr&el=tree&filepath=src%2FDataGrid.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adazzle#diff-c3JjL0RhdGFHcmlkLnRzeA==) | `86.13% <100.00%> (+4.95%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/adazzle/react-data-grid/pull/3642/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adazzle)

🚨 Try these New Features:

amanmahajan7 commented 5 days ago

It forwards the props so should be good. I can add a test in the next PR

image