search

adbahrani / MSGraphDashBoard

1 stars 3 forks source link

Ericm/dark mode #32

Open natheraf opened 7 months ago

natheraf commented 7 months ago

new color mode context and theme provider. temporary dark mode button. changed some basic html to mui components

natheraf commented 7 months ago

should i add to the theme and change some elements to make it look better? some page elements look very bad like the menu buttons that have black text against the black background in dark mode

adbahrani commented 7 months ago

should i add to the theme and change some elements to make it look better? some page elements look very bad like the menu buttons that have black text against the black background in dark mode

Hi Erik, thanks for working on this. While the idea is neat. I think in this case, the work needed outweigh the benefits as the would be quite a bit of things that has to change here. I would hold on that one for now

natheraf commented 7 months ago

let me know what you want me on next

adbahrani commented 7 months ago

let me know what you want me on next

If you have bandwidth for a decent size task, you can work on this PR https://github.com/adbahrani/MSGraphDashBoard/pull/30/files I had someone start that feel and look update and didn't get a chance to finish it. I'd say start a new PR and try to mimic that, we can even do it in portions/parts

Smaller task We need to have CSV export on all table. We have an example setup in /teams Top influences need to create a wrapper and make it apply everywhere

happy to discuss more

natheraf commented 5 months ago

Hey, it's been a month. Been busy and finally finished with my contract. Will start putting in some work to m365. Can I start with converting all HTML use Material UI components?

adbahrani commented 5 months ago

Hey, it's been a month. Been busy and finally finished with my contract. Will start putting in some work to m365. Can I start with converting all HTML use Material UI components?

Hey, sounds good. That works