adbar / htmldate

Fast and robust date extraction from web pages, with Python or on the command-line
https://htmldate.readthedocs.io
Apache License 2.0
118 stars 26 forks source link

add pre-commit with black, flake8, isort checks #142

Closed nadasuhailAyesh12 closed 6 months ago

nadasuhailAyesh12 commented 6 months ago

fiix #120

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.09%. Comparing base (3e8ba44) to head (8561fd9).

:exclamation: Current head 8561fd9 differs from pull request most recent head 373412f. Consider uploading reports for the commit 373412f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #142 +/- ## ======================================= Coverage 99.09% 99.09% ======================================= Files 8 8 Lines 880 880 ======================================= Hits 872 872 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adbar commented 6 months ago

Thanks, I'll test the PR first and then accept it if everything works.

adbar commented 6 months ago

There is something wrong with the flake8 dependency, it asks for a password.

We could also add mypy since we're at it and also the hooks suggested here:

# - repo: .. (mypy)
# ...
-   repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v2.3.0
    hooks:
    -   id: check-yaml
    -   id: end-of-file-fixer
    -   id: trailing-whitespace
adbar commented 6 months ago

It works, thanks!