search

adbayb / react-native-responsive

:package: The power of Media Queries now in your React Native project (ios and android) !
MIT License
349 stars 22 forks source link

change View.propTypes -> ViewPropTypes #6

Closed kohkimakimoto closed 7 years ago

kohkimakimoto commented 7 years ago

I'm using react-native-responsive with RN0.44, and I got a warning 

Warning: View.propTypes has been deprecated and will be removed in a future version of ReactNative. Use ViewPropTypes instead.

Please merge it to suppress the warning. Thanks for your useful package. 😄

vonovak commented 7 years ago

@adbayb could you please merge and release?

jaulz commented 7 years ago

@adbayb any chance for merging this? With React v16 it's not anymore a warning but instead an error. Thanks!

tsirlucas commented 7 years ago

Hey guys, the lib/query.js component is also broken on v16 and I think we'll have to fix it too

tsirlucas commented 7 years ago

Nevermind, just discovered that it's not fully related to the PR once @kohkimakimoto is fixing a react-native propType and the problem with v16 is a React propType on the query.js component. @kohkimakimoto mind if I fork your branch and fix the query.js component? Also, should I create a new PR in here or on your fork. Its related but not that much...

Edit

Nevermind again, @kohkimakimoto has already done the fixes on propTypes. Sorry for that haha

Edit 2

@kohkimakimoto has made the PR from the fix-propTypes branch. The React v16 propTypes fixes are on the master branch... Can you create a new PR or update this one?

kohkimakimoto commented 7 years ago

@tsirlucas I merged my master branch code to this PR. Is it OK?

tsirlucas commented 7 years ago

@kohkimakimoto Just tested it on my dev env and it's running fine. +1 to merge this PR.

adbayb commented 7 years ago

@kohkimakimoto Super. Thanks for your contribution. Can you please add a "contributors": [...] field to the package.json and include yourself into it? When it's done I'll have the pleasure to merge it :)

PS: sorry again for the long delay. I was super busy IRL :(

kohkimakimoto commented 7 years ago

@adbayb I added contributors field. Thanks!

adbayb commented 7 years ago

Merged and published to npm registry as 1.0.2 code version.

Thank you