search

adbrant / ArableInstruments

BSD 3-Clause "New" or "Revised" License
29 stars 4 forks source link

Vcv 1.0 update? #15

Closed killiun closed 5 years ago

killiun commented 5 years ago

Hello any plans to update for version 1.0?

gilbertohasnofb commented 5 years ago

Yes, that would be great. At the moment version VCV 1.x does not see any of the Arable Instrument modules.

cschol commented 5 years ago

Working on it.

adbrant commented 5 years ago

Hi, sorry I haven't had much bandwidth to look at updating these to the latest version yet. I would be happy to take a pull request and test it out though :)

cschol commented 5 years ago

@adbrant You gave me access to the repo some time ago. I'll push a v1 branch up here tonight.

cschol commented 5 years ago

@adbrant Branches uploaded: v1 and parables-v1.

Give it a test and if it works we can merge to master and parable and I will integrate it in the Plugin Manager.

adbrant commented 5 years ago

Thanks for the update, I gave it a try on my system (windows 10) and it is working well. I've merged the changes to master and parable.

cschol commented 5 years ago

Cool!

16 is strange (probably related to a very recent g++ version), but it compiles fine on my integration machine with a mingw32 cross-compile. That is what the official build system uses also.

I would not say that that should hold up the release in the Plugin Manager.

gilbertohasnofb commented 5 years ago

Any news about a possible v1.0 release?

killiun commented 5 years ago

Yeah I’m really missing it in my patches.

On Wed, Sep 11, 2019 at 2:06 PM Gilberto Agostinho notifications@github.com wrote:

Any news about a possible v1.0 release?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adbrant/ArableInstruments/issues/15?email_source=notifications&email_token=AHQG47O663OWSXP6ZCR5RQDQJFMUZA5CNFSM4H2ZEBWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6P4UJI#issuecomment-530565669, or mute the thread https://github.com/notifications/unsubscribe-auth/AHQG47K2DJCTSYB6GDK54ODQJFMUZANCNFSM4H2ZEBWA .

cschol commented 5 years ago

Integration complete.

https://github.com/VCVRack/library/issues/594 https://github.com/VCVRack/library/issues/595

adbrant commented 5 years ago

Great, thank you!