search

adbrant / ArableInstruments

BSD 3-Clause "New" or "Revised" License
29 stars 4 forks source link

Permission for inclusion in Cardinal #21

Open falkTX opened 2 years ago

falkTX commented 2 years ago

Hi there. I would like to include your modules as part of Cardinal, which the code license allows but I am unsure regarding the graphics.

The README only states:

The panel graphics in the res/ folder are copyright © Alex Brandt

But this is not a license, just a copyright notice. Would you mind placing a license for your artwork files? The CC-BY-SA is the one that most closely matches GPL in spirit, there are also optional non-commercial and non-derivate clauses possible (though that restricts what can be done with the project). Otherwise CC-0/Public-Domain allows everything,

Thanks, have a great day!

adbrant commented 2 years ago

Hello! I would be happy for these modules to be included in cardinal. The artwork in the repo are modified versions of the originals from the AudibleInstruments repo, so I am not sure if I can change the licensing. I think you should be ok to use these in the same way as the originals. I cant find the notice "The panel graphics in the res/ folder are copyright © Alex Brandt" in the repo, but I wouldn't have a problem removing it. Thanks, Alex

falkTX commented 2 years ago

The artwork in the repo are modified versions of the originals from the AudibleInstruments repo, so I am not sure if I can change the licensing. I think you should be ok to use these in the same way as the originals.

Fair enough. Luckily Emilie already gave thumbs up for its use in Cardinal. You give permission too, so all should be fine.

I cant find the notice "The panel graphics in the res/ folder are copyright © Alex Brandt" in the repo, but I wouldn't have a problem removing it.

It was added in 224610daf5e8053c31e3fc55acf7c8187314fe6b for the v2 branch.

falkTX commented 2 years ago

FYI I have tweaked the design a bit, because to be honest I find the regular one a bit ugly, and too bright. So I inverted the colors, made the panel outline work (as any other modules have) and also cleaned up and made the background png blurry. This is the result:

image

I would like to use this version for Cardinal, is that ok with you? If you like the design I can submit a PR, otherwise it will be specific to Cardinal. Due to me changing the files we cannot have both yours and my modified version at the same time though..

falkTX commented 2 years ago

Did similar things for Neil now too.

Screenshot_20220228_154502

falkTX commented 2 years ago

Hi.

I adjusted the panels to keep in mind the original artwork. Should have realized earlier that there was a point for this specific artwork and modules names.. So "Joni" one now keeps the original painting in there, in a similar fashion to what "Neil" has.

image

Should I submit these changes as pull request? Would you be interested on them?

adbrant commented 2 years ago

Sorry about the delay, yes I am interested in these changes! Thanks, Alex

On Thu, Sep 15, 2022 at 8:43 AM Filipe Coelho @.***> wrote:

Hi.

I adjusted the panels to keep in mind the original artwork. Should have realized earlier that there was a point for this specific artwork and modules names.. So "Joni" one now keeps the original painting in there, in a similar fashion to what "Neil" has.

[image: image] https://user-images.githubusercontent.com/1334853/190447178-4c1e6e47-a336-4f89-b3b4-c6d8cf7f45ff.png

Should I submit these changes as pull request? Would you be interested on them?

— Reply to this email directly, view it on GitHub https://github.com/adbrant/ArableInstruments/issues/21#issuecomment-1248281715, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACL6MCEJ5VOSTQIODRZITKTV6M72ZANCNFSM5PM63CQA . You are receiving this because you commented.Message ID: @.***>