search

adc-connect / adcc

adcc: Seamlessly connect your program to ADC
https://adc-connect.org
GNU General Public License v3.0
32 stars 19 forks source link

MacOS Big Sur Compatibility #116

Closed maxscheurer closed 3 years ago

maxscheurer commented 3 years ago

It seems that the deployed libtensorlight version is compatible with macOS 11 (Big Sur). I'm running some tests now, but I'm sure we can support it out of the box 🍏

maxscheurer commented 3 years ago

Proof:

 maxscheurer@MacBook-Pro ~/Projects/adcc    ls build
lib.macosx-11-x86_64-3.9  temp.macosx-11-x86_64-3.9
maxscheurer commented 3 years ago

In some follow-up PR, we can just apply the following diff:

diff --git a/docs/installation.rst b/docs/installation.rst
index 716c96d..4f8b61e 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -80,7 +80,7 @@ Using pip (on macOS)
 ....................

 .. attention::
-   macOS support only covers Catalina (10.15) for the moment.
+   macOS support via pip covers Catalina (10.15) and Big Sur (11.0).
    For other macOS versions, please :ref:`install adcc using conda <install-conda>`.

 The installation on macOS requires a ``clang`` compiler.
mfherbst commented 3 years ago

See https://github.com/adc-connect/adcc/pull/117