Add LGTM

[maxscheurer]

Add LGTM Badge and automatic PR review.

[lgtm-com[bot]]

This pull request fixes 3 alerts when merging 3e9676d8a8fd44f4756f62af8d0f9ad3b949c03f into d549059f14d8ca9c3764241961c25f268820956f - view on LGTM.com

fixed alerts:

• 1 for Unused local variable
• 1 for Unnecessary 'else' clause in loop
• 1 for Unreachable code

[maxscheurer]

How about we change the table to this format:

[mfherbst]

Actually I dislike that too. I think psi4 is overdoing it a little with the badges. I'd just add a section in the text (like the citations) about code quality or code status or sth like that?

[maxscheurer]

I didn't mean that we should add all these badges 😄 But instead of having rows instead of columns for Documentation, Build Status and Installation. Then the code quality thing can be added to build status, where it fits best I guess. But if you like the extra section better, we can do that too 😉

[mfherbst]

Ah I see. Hmm I don't mind rows. Let's see what it looks like.

[mfherbst]

Much better. Now the last thing that bothers me is that the LGTM badge is quite wide. Since we don't really have any other language at the moment, can we just drop the logo and the language in the badge?

[lgtm-com[bot]]

This pull request fixes 3 alerts when merging e19c01589845b089259ad7efc5f9cf7668cf79c5 into d549059f14d8ca9c3764241961c25f268820956f - view on LGTM.com

fixed alerts:

• 1 for Unused local variable
• 1 for Unnecessary 'else' clause in loop
• 1 for Unreachable code

[maxscheurer]

can we just drop the logo and the language in the badge?

I've dropped the logo, but the language cannot be removed unfortunately. But now it's already less wide...

[mfherbst]

language cannot be removed unfortunately

Nobody stops you from making a custom shield.io logo :smile:

[lgtm-com[bot]]

This pull request fixes 3 alerts when merging deea76fdcd431291a704a41dcf8bd686b344db1a into d549059f14d8ca9c3764241961c25f268820956f - view on LGTM.com

fixed alerts:

• 1 for Unused local variable
• 1 for Unnecessary 'else' clause in loop
• 1 for Unreachable code

[maxscheurer]

Nobody stops you from making a custom shield.io logo

Done 😄 The label can be overridden...

[lgtm-com[bot]]

This pull request fixes 3 alerts when merging 7cd05a5a47f67659087e0945bf4ca0aa4996ea70 into d549059f14d8ca9c3764241961c25f268820956f - view on LGTM.com

fixed alerts:

• 1 for Unused local variable
• 1 for Unnecessary 'else' clause in loop
• 1 for Unreachable code