search

adc-connect / adcc

adcc: Seamlessly connect your program to ADC
https://adc-connect.org
GNU General Public License v3.0
32 stars 20 forks source link

Loosen platform restrictions #99

Closed mfherbst closed 3 years ago

maxscheurer commented 3 years ago

I get the same error as the CI. In my case os_platform_tag equals "macosx_10_15_x86_64".

mfherbst commented 3 years ago

Ah hmm. Can you try adapting the code and just push what works on your end?

mfherbst commented 3 years ago

Ah no the issue is the replace in https://github.com/adc-connect/adcc/blob/master/extension/AdcCore.py#L38 Can you just use the distutils call without calling get_platform?

mfherbst commented 3 years ago

@maxscheurer Could you try again on your machine?

maxscheurer commented 3 years ago

Yes, I was on the road, so I couldn't do anything 😄 Will test it now...

mfherbst commented 3 years ago

Ok cool, so we only need to build on 10.14 and we're able to support 10.15 out of the box.