search

add-ons / plugin.video.viervijfzes

Kodi add-on to watch video-on-demand content from the Play 4, Play 5 and Play 6 channels.
https://github.com/add-ons/plugin.video.viervijfzes/wiki
GNU General Public License v3.0
50 stars 10 forks source link

Add support for Python 3.9 #60

Closed michaelarnauts closed 3 years ago

michaelarnauts commented 3 years ago
dagwieers commented 3 years ago

Python 3.5 may still be around on older Kodi boxes, so I would keep it around for some time. (I listed this somewhere in a ticket when we implemented a workaround for Python 3.5 because it affected users)

mediaminister commented 3 years ago

Python 3.5 is used with OSMC on Debian Stretch: https://github.com/add-ons/plugin.video.vrt.nu/pull/586

michaelarnauts commented 3 years ago

Hmm, that's odd. As far as I know, there is no version of OSMC with debian stretch that has Kodi 19 (and thus is using Python 3.5). The beta versions of Kodi 19 all run on debian buster, and they have Python 3.7.

I can add the tests for py35 back since the addon is compatible anyway, i just didn't want to extend the CI time.

dagwieers commented 3 years ago

That is up to you. At some point this was the case (and it may still be, albeit not with OSMC).

IMO it is easier to keep it while we still support Python 2.7 anyway. We have one workaround implemented specifically for Python 3.5 too.

Unless we are forced into it again, I prefer to remove all legacy code when we stop supporting Python 2.7. At that point I would also like to rewrite quite a bit using newer idioms, like the f-string.