add-ons / script.speedtester

Kodi add-on for testing your Internet bandwidth
Apache License 2.0
5 stars 5 forks source link

Reads ping, hangs on speed test, Kodi 20 RC2 #26

Open siliconhippy opened 1 year ago

siliconhippy commented 1 year ago

Hi !

I used AE-PCx86-11.0.18 Kodi 20 beta ( from AlexElec.tv repo, a fork of CoreElec) and the Speedtest addon worked fine.

However with the AE 11.0.19 version with Kodi 20 RC2, the addon shows ping but hangs at the speed test part. See Kodi error log pic attached.

IMG_20230115_023632

newf276 commented 1 year ago

Same issue on LibreELEC Nexus final, and Kodi final Nexus for both Android and OSX. Ping only, but does not calculate speed .. No error log, as one is not produced.

strolch89 commented 1 year ago

SOLVED!

Same issue. LibreELEC 20.1-Nexus on RPI4. Ping only but no speedtest.

2023-05-03 12:29:28.012 T:805      info <general>: Loading skin file: /storage/.kodi/addons/script.speedtester/resources/skins/Default/720p/script-speedtester_main.xml, load type: LOAD_ON_GUI_INIT
2023-05-03 12:29:33.365 T:1284    error <general>: Exception in thread 
2023-05-03 12:29:33.366 T:1284    error <general>: Thread-2 (consumer)
2023-05-03 12:29:33.366 T:1284    error <general>: :

2023-05-03 12:29:33.366 T:1284    error <general>: 
2023-05-03 12:29:33.366 T:1284    error <general>: Traceback (most recent call last):

2023-05-03 12:29:33.366 T:1284    error <general>: 
2023-05-03 12:29:33.366 T:1284    error <general>:   File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner

2023-05-03 12:29:33.367 T:1284    error <general>: 
2023-05-03 12:29:33.367 T:1284    error <general>:   File "/usr/lib/python3.11/threading.py", line 975, in run

2023-05-03 12:29:33.374 T:1284    error <general>: 
2023-05-03 12:29:33.374 T:1284    error <general>:   File "/storage/.kodi/addons/script.speedtester/resources/lib/addon.py", line 738, in consumer

2023-05-03 12:29:33.389 T:1284    error <general>: 
2023-05-03 12:29:33.389 T:1284    error <general>:     
2023-05-03 12:29:33.389 T:1284    error <general>: while thread.isAlive():
2023-05-03 12:29:33.389 T:1284    error <general>: 

2023-05-03 12:29:33.389 T:1284    error <general>: 
2023-05-03 12:29:33.389 T:1284    error <general>:  
2023-05-03 12:29:33.389 T:1284     info <general>: Skipped 9 duplicate messages..
2023-05-03 12:29:33.389 T:1284    error <general>: ^
2023-05-03 12:29:33.390 T:1284     info <general>: Skipped 13 duplicate messages..
2023-05-03 12:29:33.390 T:1284    error <general>: 

2023-05-03 12:29:33.390 T:1284    error <general>: 
2023-05-03 12:29:33.390 T:1284    error <general>: AttributeError
2023-05-03 12:29:33.390 T:1284    error <general>: : 
2023-05-03 12:29:33.390 T:1284    error <general>: 'FileGetter' object has no attribute 'isAlive'
2023-05-03 12:29:33.390 T:1284    error <general>: . Did you mean: '
2023-05-03 12:29:33.390 T:1284    error <general>: is_alive
2023-05-03 12:29:33.390 T:1284    error <general>: '?
2023-05-03 12:29:33.390 T:1284    error <general>: 

2023-05-03 12:29:33.443 T:1279    error <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'AttributeError'>
                                                   Error Contents: 'Thread' object has no attribute 'isAlive'
                                                   Traceback (most recent call last):
                                                     File "/storage/.kodi/addons/script.speedtester/resources/lib/addon.py", line 658, in onClick
                                                       self.speedtest(share=True, simple=True)
                                                     File "/storage/.kodi/addons/script.speedtester/resources/lib/addon.py", line 860, in speedtest
                                                       dlspeed = self.download_speed(urls, simple)
                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                                     File "/storage/.kodi/addons/script.speedtester/resources/lib/addon.py", line 752, in download_speed
                                                       while prod_thread.isAlive():
                                                             ^^^^^^^^^^^^^^^^^^^
                                                   AttributeError: 'Thread' object has no attribute 'isAlive'
                                                   -->End of Python script error report<-

To solve this, just as ajbathe in another thread recommends. I changed isAlive() into is_alive() in multiple lines in the script. Now it workes fine for me. Thank you ajbathe.

atrugiel69 commented 3 months ago

The above solition worked for me too. It should be merged.