add-ons / service.iptv.manager

Integrate TV and radio channels with EPG data from other add-ons in Kodi PVR.
https://github.com/add-ons/service.iptv.manager/wiki
GNU General Public License v3.0
95 stars 28 forks source link

Bugfix: ContextMenu.Play Format uri string if there is a duration present. #32

Closed MarcelRoozekrans closed 4 years ago

michaelarnauts commented 4 years ago

You are right. Calling isoformat on the duration was obviously wrong. How did you trigger the bug? Are you trying to integrate another addon? Any other placeholders that could be usefull?

MarcelRoozekrans commented 4 years ago

Yeah, nearing completion of a NLZIET addon where I implemented the iptvmanager. The starttime and duration is exactly what I needed to request the right stream.

michaelarnauts commented 4 years ago

Okay, I see.

I was thinking to use the middle of the program (starttime + duration/2), since I've noticed that when the network changes the EPG due to small changes in the schedule, it can start the previous program instead (it does a lookup to find a program that airs at the starttime, and this doesn't work when a program is shifted 5 minutes later. Something that happens with VRT Nu).

michaelarnauts commented 4 years ago

This is only needed for Kodi 18 btw, in Kodi 19, I use the stream parameter from the JSON-EPG.

I'm also thinking of using this information also in Kodi 18 to directly start the right stream, so we don't need to do the lookup. I would need to cache the dict then somehow, or parse the xml to look for the stream.

What are the possibilities with NLZIET?

michaelarnauts commented 4 years ago

I'll merge this one, and we can continue in #29 for this.