add-ons / service.iptv.manager

Integrate TV and radio channels with EPG data from other add-ons in Kodi PVR.
https://github.com/add-ons/service.iptv.manager/wiki
GNU General Public License v3.0
95 stars 28 forks source link

Cleanup code by removing play by airdate #49

Closed michaelarnauts closed 3 years ago

michaelarnauts commented 3 years ago

In Kodi 19, we have a nice way to play vod content, by using the catchup-id in the xmltv file. This isn't supported in Kodi 18, so I had to create some workarounds.

Initially, I've had implemented a templated url on the channel-level that could be filled in to play something from the EPG, like plugin://plugin.video.example/play/bbc1/airdate/{start}/{stop}. This didn't work correctly for multiple reasons:

Later, I added another "hack" to hide the URL in the name of the program (I do this only in Kodi 18), and extract it when the from the sys.listitem when the user asks to play this trough a context emnu. This method is a lot more accurate, and is a lot less code.

The first implementation hasn't been removed until now, but no addon that we know of is using it. And they shouldn't, since it won't work in Kodi 19.

This has a few benefits:

This also makes the vod attribute from the JSON-STREAMS format useless.