[Bug]: subscribe button doesn't render unless there is a startDate

justin-hackin commented 7 months ago

What happened?

When using react component to create an ics subscribe button, the component doesn't render unless there is a startTime. It's confusing, why does a subscription need a start time? The typescript types don't seem to indicate this as a required property either.

How to reproduce?

Render this:

<AddToCalendarButton
        name={'Cal'}
        options={['Apple', 'Google', 'Yahoo', 'iCal']}
        icsFile={'http://......'}
        subscribe
    ></AddToCalendarButton>

and then observe button doesn't render. Add startDate, notice button renders.

Screenshots & more

No response

System & Environment

Apple M1 , macOS Ventura Version 13.4 (22F66) , Chrome Version 122.0.6261.129 (Official Build) (arm64), package version "add-to-calendar-button-react": "^2.6.8", via npm

P.S. It's better to populate this with template text rather than use a placeholder to list requirements because as soon as the reporter types anything they lose sight of the requirements.

jekuer commented 7 months ago

Changed with v2.6.9

justin-hackin commented 6 months ago

Changed with v2.6.9

Thanks for addressing this 🎉

add2cal / add-to-calendar-button