search

addianto / botofculture-discord

Ah. I see you are looking for a bot of culture.
MIT License
2 stars 1 forks source link

Bug: Error Sending Large Image #2

Open adrika-novrialdi opened 4 years ago

adrika-novrialdi commented 4 years ago

If an image from the link has big size, the bot apparently can't send it as intended. I suppose this issue is related with image size limit in Discord. I guess It will better if the bot has mechanism for handling this kind of request by sending "Image too large" response or similar.

thrzl commented 3 years ago

If I see the code right, the bot downloads the images. What if it just sent the link of the image? Discord creates link previews, so if I send a link to an image file, it will show the actual image and not the link.

Maybe you could also use an embed to send the images and use embed.set_image(url=url)

addianto commented 3 years ago

Hey. Sorry for leaving out this issue for so long.

Maybe you could also use an embed to send the images and use embed.set_image(url=url)

This is a good idea. The change is also minimal, so it could be implemented quickly.

Alternatively, the image could be uploaded to image host such as imgur programatically and embed the link to imgur in the reply message. But that will add extra work and an extra service to handle. 😅 The purpose of having this bot is to have the image in Discord, not by accessing other service.

thrzl commented 3 years ago

I don't quite see the need for an external uploader. I agree that it will add extra work and steps.

By the way, I would have submitted a pull request but I don't have twitter so I couldn't have tested it 😳

addianto commented 3 years ago

I'll keep this issue open then for future contributors. Thanks for the input. 👍