addictgamer / Terrastation-13

Custom space station 13 server created by terraform gaming. Based off of TGS and Paradise.
Other
5 stars 8 forks source link

Comment & clean & reorganize code & resources #4

Closed addictgamer closed 9 years ago

addictgamer commented 11 years ago

This is here mostly for the purpose of the milestone.

This requires Tauka's organized-in-works branch being completed and merged with master. I use the term "merge" loosely, not specifically referring to git's merge function.

This also requires all the code to be commented and the data, such as sprites & sounds, to be better organized.

taukausanake commented 11 years ago

You do know that "merging" my code and the master code is going to make a shit load of problems, yes? Once my branch is finished (everything separated and organized) it'll have to catch up with the master branch, after which it can be "merged". I want them to be the same though so whichever is nicer to be modded by whoever, the other will just have to be modded too. I say they stay separate

addictgamer commented 11 years ago

THAT ^ is EXACTLY why I wrote "I use the term 'merge' loosely, not specifically referring to git's merge function."

taukausanake commented 11 years ago

So merge means update organized to catch up with master? I've only made small changes in adding things. Barely anything useable

addictgamer commented 11 years ago

Well, pretty much. Take organized and make it the main and add everything we've added to master to it.

taukausanake commented 10 years ago

So with the new Bay12 version of Terrastation being much better than the last, and my organized branch being based off the last, I'm wondering if it would matter if I started over. A problem that comes with how I "organized" everything is that I made files for everything and that increased load time by a lot. I need to know what the rest of you think would be better if I'm to continue with any of this.

addictgamer commented 10 years ago

Well, it's kinda redundant. I want to say this issue is mostly closed, save for commenting code.

taukausanake commented 10 years ago

I still don't like how half the code is ordered. I don't know why many of the things are placed in code/modules/ and others in the code/games/. Maybe it's due to a complete set but that still makes finding things a little confusing. Also when you do a search for an object of any type you'd expect to find the actual object define, not a proc that it uses. I don't really understand but is it beneficial to have less files with more data in them or the other way around? When I was giving every object a file I noticed an increase in load time. Spess still takes a while to load even now but that's a given. Which way would be more ideal in coding?

addictgamer commented 10 years ago

@taukausanake: A) Which is faster all depends on the compiler (and thus, language) and compile settings. And, of course, the operating system and runtime libraries involved.

B) Don't forget that if you don't have the databases set up on your local machine, it will take a good bit of more time to start up. At the very least, I noticed that it starts way faster after I set up the mysql databases.

C) In general, everything related to one...thing, should be in the same file.

taukausanake commented 10 years ago

I guess it wouldn't be such a bad idea to try and start this over again. More like equal halves good and bad. I feel like I'm the only coder for this more or less seeing that you don't like Byond language and have a bunch of other projects up. Is that a fair statement to use?

addictgamer commented 10 years ago

Mmmm, for the moment.

LZakida commented 9 years ago

Closed because no longer relevant.