search

addr-rs / addr

Parse domain names reliably and quickly in Rust
MIT License
51 stars 12 forks source link

Docs fail to build on docs.rs #6

Closed antonok-edm closed 3 years ago

antonok-edm commented 4 years ago

Thanks for this excellent library.

It appears psl has been causing the documentation on docs.rs for the adblock crate to fail to build for quite some time now. However, it looks like the documentation for both psl and addr build without issues. I'm curious if you have any insight as to what the difference might be.

Original issue reported here: https://github.com/brave/adblock-rust/issues/86

Nemo157 commented 4 years ago

The reason the psl docs built fine is that they're from before the sandboxing was implemented. Only since Oct 2019 was the lack of network access enforced.

antonok-edm commented 4 years ago

@Nemo157 good find, that looks correct - I've added my +1 on the docs.rs issue

john-consumable commented 3 years ago

Is it possible to remove the network requirement to build addr? It doesn't just effect docs.rs, it also effects people building offline and people using nix or other functional package managers to build their software.

john-consumable commented 3 years ago

Hm. Wait, I think I understand that using $PSL_PATH should make it unnecessary to go to the network, sorry for the noise!

rushmorem commented 3 years ago

Now fixed. psl 1.0.0 is now out and it no longer downloads the list during the build.