addshore / addframe

OLD addwiki framework (See the newer https://github.com/addwiki libraries)
7 stars 2 forks source link

WikiText->getUrls returns more than just urls #112

Closed addshore closed 10 years ago

addshore commented 10 years ago

Currently this functions will match things that are not specifically http: or https: due to the need to match //en.wikipedia.org etc.

There should be a sort of reverse lookup added to the url regex meaning it cannot match things such as ssh!

legoktm commented 10 years ago

var_dump(filter_var('example.com', FILTER_VALIDATE_URL)); ?

http://stackoverflow.com/questions/206059/php-validation-regex-for-url has some interesting comments.

addshore commented 10 years ago

This is a bug from the last framework version.... (no longer relevant) We may address this when the framework gets to such a point again