addshore / wikicrowd

Tool for crowd sourced micro edits for Wikimedia
https://wikicrowd.toolforge.org/
MIT License
7 stars 4 forks source link

Improve phrasing of "depicts" question #12

Closed waldyrious closed 2 years ago

waldyrious commented 2 years ago

Cognitively it's easier to see the name of the item followed by its QID than the opposite. This is also helpful in mobile phones, where screen space is more limited.

The underlining is also removed because it is typically associated with a link, when in this case the QID is (also) linked. Alternatively, we could keep the item name inside the link and underline the whole thing (though that would be better done via CSS than the <u> tag).

Finally, a question mark is added to make the sentence grammatically correct :)

Before: Screenshot from 2022-01-09 12-16-06

After: Screenshot from 2022-01-09 12-17-12

addshore commented 2 years ago

Sounds great, I'll try and make this change. I also need to rework how the question text is generated / stored and presented internally.

waldyrious commented 2 years ago

Sounds great, I'll try and make this change.

Just in case that went unnoticed, this is a PR, not an issue :)

Edit: I now see you added yourself as a reviewer, so it seems it was just the wording you used that threw me off. In any case, feel free to discard this PR entirely if the implementation would require a different approach.

addshore commented 2 years ago

Just in case that went unnoticed, this is a PR, not an issue :)

I think I missed that somehow while readin this before! :D