search

addthis / metrics-reporter-config

Apache License 2.0
74 stars 52 forks source link

Multiple code improvements - squid:S1066, squid:S1149, squid:UselessParenthesesCheck, squid:S1488, squid:UnusedPrivateMethod, squid:S3398, squid:S00115, squid:S1213, squid:S1068 #21

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1066 - Collapsible "if" statements should be merged. squid:S1149 - Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. squid:S1488 - Local Variables should not be declared and then immediately returned or thrown. squid:UnusedPrivateMethod - Unused private method should be removed. squid:S3398 - "private" methods called only by inner classes should be moved to those classes. squid:S00115 - Constant names should comply with a naming convention. squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order. squid:S1068 - Unused private fields should be removed. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1066 https://dev.eclipse.org/sonar/rules/show/squid:S1149 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck https://dev.eclipse.org/sonar/rules/show/squid:S1488 https://dev.eclipse.org/sonar/rules/show/squid:UnusedPrivateMethod https://dev.eclipse.org/sonar/rules/show/squid:S00115 https://dev.eclipse.org/sonar/rules/show/squid:S1213 https://dev.eclipse.org/sonar/rules/show/squid:S1068 Please let me know if you have any questions. George Kankava

yuesong commented 8 years ago

Thanks!