search

addthis / metrics-reporter-config

Apache License 2.0
74 stars 52 forks source link

2.1.1 #25

Open ianilsley opened 8 years ago

ianilsley commented 8 years ago

This is to address - https://github.com/addthis/metrics-reporter-config/issues/24

If the directory already exists then no metrics will gathered as we return false . This is understandable as you may not want to overwrite existing metrics . The patch gets around this by renaming the existing directory to name+currentSystemtimeinmillis . and then recreate the original directory .

yuesong commented 8 years ago

This pull request modifies a release version on the java8 branch. Is there any reason why this change should not be made on master?

ianilsley commented 8 years ago

Dont see why not , I just needed it for a 2.1.0 branch . But it could be forward ported I guess :) .