search

addthis / metrics-reporter-config

Apache License 2.0
74 stars 52 forks source link

Support RiemannReporter #5

Closed dlobue closed 10 years ago

dlobue commented 10 years ago

This adds support for the riemann reporter included in the riemann java client.

Props to Aaron Morton who wrote about his verison of this addition in his blog: http://thelastpickle.com/blog/2013/11/22/4-hours-with-riemann.html but forgot to push the code to github!

cburroughs commented 10 years ago

Thanks for putting this together dlobue.

Is there a way to use a Riemann library in maven central? I think <repositories> currently get a big frowny face instead of a straight up rejection from the maven central lords (where metics-reporter-config needs to be able to live) but I'd prefer to avoid that if possible.

dlobue commented 10 years ago

@cburroughs that's actually the official java client lib from the author of riemann.

I had an idea about making RiemannReporter an external package, if including that library is a no-go. Specifically I was thinking along the lines of how log4j allows you to use appenders from other packages. Just not sure exactly how to implement it :(

cburroughs commented 10 years ago

Still thinking about how to handle the maven central rules. Otherwise I think everything looks good.

pgorla-zz commented 10 years ago

Hey, thanks for building this. Just wanted to check if the maven issues had been sorted out — I tested this build locally and Riemann is running without any errors.

cburroughs commented 10 years ago

Merged! Sorry for the delay.

I added an exclusion for metrics 2.x and 3.x being pulled in by riemann-java-client. (Since metrics-reporter-config ought to have that as an explicit setting.) If riemann-java-client itself was using metrics-core somehow I didn't appreciate that could cause a problem.

cburroughs commented 10 years ago

Released in 2.3.0, which should be on it's way to maven central.

pgorla-zz commented 10 years ago

Great news, thanks!