search

addthis / metrics-reporter-config

Apache License 2.0
74 stars 52 forks source link

Codahale metrics 3 #6

Closed dlobue closed 10 years ago

dlobue commented 10 years ago

Updated code to work with codahale metrics >= 3.

Currently using a version of this that contains a riemann reporter in one of the projects I work on that uses codahale metrics 3.

Not sure if this should be merged into master, or a separate branch so both versions of the metrics library can be supported at the same time or what.

cburroughs commented 10 years ago

I have not gotten a chance to digest all of the changes in 3.x yet, so I'm not as familiar as I should be. (Existing working code, other things to do, etc) So the short answer is I'm not sure how to handle it either.

My understanding is that 2.x and 3.x are supposed to be able to co-exist together. At least as an ideal that's more appealing to me than maintaining two branches for a long time.

dlobue commented 10 years ago

@cburroughs sure. I have an idea on how to go about this. I'll do that and submit a new PR.