CountMinSketch is not serializable

[gokyo]

Could we make com.clearspring.analytics.stream.frequency.CountMinSketch implementing java.io.Serializable please?

I am getting this error: org.apache.commons.lang3.SerializationException: java.io.NotSerializableException: com.clearspring.analytics.stream.frequency.CountMinSketch at org.apache.commons.lang3.SerializationUtils.serialize(SerializationUtils.java:156)

[abramsm]

CountMinSketch has serialize and deserialize in the current implementation. It should be possible to extend the Serializable interface as well. Have you looked to see if using the serialize/deserialize methods is viable for you? Are you interested in submitting a pull request that makes the desired modification?

[gokyo]

Using serialize and deserialize would make my code complex. Best for me would be to implement Serializable as it requires only a simple change on your code, and no changes on my code. I can create a pull request if it is fine for you guys. Thanks

[gokyo]

I created the pull request on here: https://github.com/addthis/stream-lib/pull/110 On my local machine the Maven build passed. Both mvn clean install test and mvn test -B build successfully. It is compatible with both Java 7 and Java 8. But one of your three builds failed unfortunately: https://travis-ci.org/addthis/stream-lib/builds/136229647 I believe my code changes are fine. Let me know if the change can be merged and released. Thanks

[gokyo]

Hi Any news on this ticket? Thanks

[yuesong]

Sorry for the delay. The code looks fine. I'll do a final pass over.

[gokyo]

Thanks Let me know when can be merged and released :+1:

[gokyo]

I close the issue as the code has been merged

[yuesong]

It's released.

[gokyo]

Thanks :+1: