There are no checks on the Count-Min Sketch parameters

addthis / stream-lib

Stream summarizer and cardinality estimator.

Apache License 2.0

2.26k stars 556 forks source link

There are no checks on the Count-Min Sketch parameters #117

Closed gokyo closed 7 years ago

gokyo commented 8 years ago

During the construction of the count-min sketches I suggest to make some checks to the parameter values. I am talking of width, depth, confidence, epsilon. I would require the Count-Min Sketch user to use only some values in a range [minimum allowed value, maximum allowed value]. In this ways "possible surprises" are avoided.

abramsm commented 7 years ago

closing due to inactivity. happy to re-open if there is a volunteer to investigate further.