addyosmani / backbone-fundamentals

:book: A creative-commons book on Backbone.js for beginners and advanced users alike
http://addyosmani.github.io/backbone-fundamentals/
9.25k stars 1.41k forks source link

Problems in chapter "MarionetteJS (Backbone.Marionette)" #467

Open lachezar opened 11 years ago

lachezar commented 11 years ago

I am new to Backbone and I was hoping to read on Marionette, but I noticed few problematic things:

The part explaining about Marionette's Layout is very unclear to me in general. Looking in the documentation of Marionette I see different usage than the one described in this book (e.g. there is an attribute regions defined within the Layout and in the book it is missing). Also this chapter states that the Header is a Layout, but the source code afterwards extends from Marionette.ItemView.

// Layout Header View
// ------------------

Layout.Header = Marionette.ItemView.extend({

Otherwise, thanks for the efforts and the book looks great so far!

addyosmani commented 11 years ago

Thank you for reporting this. I think we need to spend time reviewing the changes to the more recent versions of Marionette and adjust the chapter accordingly.

ambroselittle commented 11 years ago

I was going to report the same exact thing. Most of the chapter is easy to follow, but this part had me re-reading a couple times. Okay, I was really tired the first time I read, but still. :)

Also, maybe a general suggestion, it would help to show a diagram of the project structure up front, as well as a diagram showing call dependencies between the files/modules. And finally, simple flow diagrams showing from app start to loading up the list, adding an item, and checking an item. This sort of architectural overview would help a lot before diving into the particular pieces of it.

addyosmani commented 10 years ago

This chapter requires a rewrite to bring it in line with the latest versions of Marionette. I haven't had a chance to do this yet, but will try to make out time to. Any assistance is appreciated of course :)